From 7a2cec3945ba700c674f816d47f49060975b854d Mon Sep 17 00:00:00 2001
From: Joel Grunbaum <joelgrun@gmail.com>
Date: Fri, 23 Oct 2020 05:52:50 +0000
Subject: [PATCH] renamed shadowed variable

---
 main.c |   19 +++++++++++++------
 1 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/main.c b/main.c
index 5fb4cf2..3e263dd 100644
--- a/main.c
+++ b/main.c
@@ -30,13 +30,13 @@
 int main(int argc, char** argv)
 {
 	int option, added_hosts = 0;
-	while((option = getopt(argc, argv, "s:h:t:n:")) != -1) {
+	while((option = getopt(argc, argv, "s:a:t:n:h")) != -1) {
 		switch (option) {
 		case 's': //server to use
 			add_dns_server(&servers, optarg);
 			num_servers++;
 			break;
-		case 'h': //hostname to search
+		case 'a': //hostname to search
 			add_hosts_server(&hosts, optarg);
 			added_hosts++;
 			break;
@@ -47,8 +47,15 @@
 			num_tests = atoi(optarg);
 			break;
 		case '?':
+		case 'h':
 		default:
-			printf("Error: invalid option -%c\n", optopt);
+			printf("Usage: %s [options]\n", argv[0]);
+			printf("Options:\n");
+			printf("\t-s <server>\tadd a DNS server to be tested\n");
+			printf("\t-a <hostname>\tadd a hostname to be tested\n");
+			printf("\t-t <number>\tspecify the number of hostnames to be tested, capped at 50 + number manually added\n\t\t\tdefaults to test all available\n");
+			printf("\t-n <number>\tspecify the number of tests to perform on each hostname\n\t\t\tdefaults to 10\n");
+			printf("\t-h\t\tShow this help\n");
 			free_dns_list(&servers);
 			free_hosts_list(&hosts);
 			exit(1);
@@ -58,10 +65,10 @@
 		num_hosts = NUM_HOSTNAMES + added_hosts;
 	}
 	for (int i = added_hosts; i < num_hosts; i++) {
-		add_hosts_server(&hosts, HOSTNAMES[i-added_hosts]);
+		add_hosts_server(&hosts, (char*)HOSTNAMES[i-added_hosts]);
 	}
 	for (int i = 0; i < NUM_DNS; i++) {
-		add_dns_server(&servers, DNS_SERVERS[i]);
+		add_dns_server(&servers, (char*)DNS_SERVERS[i]);
 	}
 	test_dns();
 	sort_servers(&servers);
@@ -106,7 +113,7 @@
 			struct timespec run;
 			run.tv_sec = -1; run.tv_nsec = 0;
 			unsigned char buf[65536];
-			for (int i = 0; i < 3 && run.tv_sec == -1; i++) {
+			for (int j = 0; j < 3 && run.tv_sec == -1; j++) {
 				run = resolve(buf, curr->server, dns->server, T_A);
 			}
 			if (run.tv_sec == -1) //if test has failed 3 times, set time taken to 3s as penalty

--
Gitblit v1.10.0